Pass exact through point intersections#395
Open
Maximus-08 wants to merge 2 commits intoJuliaGeo:mainfrom
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR makes the exact predicate-mode keyword controllable from the supported public point-intersection APIs, so callers can explicitly choose the exact vs inexact predicate path rather than being forced into the default.
Changes:
- Exposes
exactonintersection_points(...)entrypoints and forwards it down to_intersection_points. - Adds
exacttointersection(...; target = GI.PointTrait())by passing it through to the point-intersection implementation. - Adds regression tests covering both public point-intersection paths with
exact = false.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
src/methods/clipping/intersection.jl |
Threads exact through intersection (PointTrait target) and intersection_points to _intersection_points, and updates intersection_points docs. |
test/methods/clipping/intersection_points.jl |
Adds regression tests ensuring exact = false works via both intersection_points and intersection(...; target=PointTrait()). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Avnish Jaltare <avnishjaltare8@gmail.com>
Signed-off-by: Avnish Jaltare <avnishjaltare8@gmail.com>
Maximus-08
force-pushed
the
issue-167-point-intersection-exact
branch
from
0089319 to
372744a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
exactkeyword on publicintersection_pointsentrypointsexactthroughintersection(...; target = GI.PointTrait())to_intersection_pointsexact = falseBefore this change:
_intersection_points(...; exact=...)already supported the keywordintersection_points(...)dropped itintersection(...; target = GI.PointTrait())also dropped itThat meant users could not control the exact/inexact predicate path from the supported public APIs.
Testing
Documenter errors like CurrentModule = GeometryOpsCore failing because GeometryOpsCore was not defined in Main during doctest evaluation. This error is also seen in the CI doctest